Re: [PATCH 03/10] tty: pxa: configure pin
From: Linus Walleij <hidden>
Date: 2012-10-24 05:43:22
Also in:
linux-arm-kernel
On Tue, Oct 23, 2012 at 1:58 PM, Mark Brown [off-list ref] wrote:
One problem is that we don't have a home for the SoC integration so we're trying to shove it all into the drivers which just leads to a stack of pointless boilerplate when the driver isn't actually doing anything beyond the basic pattern of turning everything off when it goes idle and turning it on again when it needs to do something. Having to open code that stuff in the drivers and then deal with the stubbing and error handling so the error handling in the drivers is painful. There's also another axis where things aren't part of a SoC but are separate devices so you want to carry things along with the driver rather than have a separate bit of code which is required to glue things into the platform.
I agree. I'm thinking about the approach of adding helpers into the PM runtime layer so state handling is centralized, while only the event trigger goes into the driver. Basically it's just the implicit triggers from pm_runtime_[get|put][[_sync] that is causing problems. Yours, Linus Walleij