[PATCH 07/10] pinctrl: remove mutex lock in groups show
From: Haojian Zhuang <hidden>
Date: 2012-10-18 09:07:01
Also in:
linux-arm-kernel
Subsystem:
pin control subsystem, the rest · Maintainers:
Linus Walleij, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2012-10-22 · Re: [PATCH 07/10] pinctrl: remove mutex lock in groups show · Linus Walleij <hidden>
- 2012-10-18 · Re: [PATCH 07/10] pinctrl: remove mutex lock in groups show · Stephen Warren <hidden>
- 2012-10-18 · Re: [PATCH 07/10] pinctrl: remove mutex lock in groups show · Linus Walleij <hidden>
Mutex is locked duplicatly by pinconf_groups_show() and pin_config_group_get(). It results dead lock. So avoid to lock mutex in pinconf_groups_show(). Signed-off-by: Haojian Zhuang <redacted> --- drivers/pinctrl/pinconf.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 43f474c..baee2cc 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c@@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) seq_puts(s, "Pin config settings per pin group\n"); seq_puts(s, "Format: group (name): configs\n"); - mutex_lock(&pinctrl_mutex); - while (selector < ngroups) { const char *gname = pctlops->get_group_name(pctldev, selector);
@@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) selector++; } - mutex_unlock(&pinctrl_mutex); - return 0; }
--
1.7.0.4