Re: [PATCH v3 4/6] dts: exynos: add device tree support for exynos5 hdmiddc
From: Tomasz Figa <hidden>
Date: 2012-10-16 09:04:45
Also in:
linux-samsung-soc
Hi, On Tuesday 16 of October 2012 05:00:32 Rahul Sharma wrote:
quoted hunk
This patch adds support for device tree based discovery for exynos5 hdmi ddc. Signed-off-by: Rahul Sharma <redacted> --- .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ++++++++++++ arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +++++++++- arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ 3 files changed, 23 insertions(+), 1 deletions(-) create mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiddc.txtdiff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txtb/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt new file mode 100644 index 0000000..c408892--- /dev/null +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt@@ -0,0 +1,12 @@ +Device-Tree bindings for hdmiddc driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmiddc". +- reg: I2C address of the hdmiddc device. + +Example: + + hdmiddc { + compatible = "samsung,exynos5-hdmiddc"; + reg = <0x50>; + };\ No newline at end of filediff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dtsb/arch/arm/boot/dts/exynos5250-smdk5250.dts index 18ac213..f7b4fc4 100644--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts@@ -56,7 +56,15 @@ }; i2c@12C80000 { - status = "disabled"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <66000>; + gpios = <&gpa0 6 3 3 0>, + <&gpa0 7 3 3 0>; + + hdmiddc@50 { + compatible = "samsung,exynos5-hdmiddc"; + reg = <0x50>; + }; }; i2c@12C90000 {diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.cb/arch/arm/mach-exynos/mach-exynos5-dt.c index 3f129db..003963c 100644--- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c@@ -47,6 +47,8 @@ static const struct of_dev_auxdataexynos5250_auxdata_lookup[] __initconst = { "s3c2440-i2c.0", NULL), OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1), "s3c2440-i2c.1", NULL), + OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(2), + "s3c2440-i2c.2", NULL), OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS5_PA_IIC(8), "s3c2440-hdmiphy-i2c", NULL), OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI0,
Looks fine. Reviewed-by: Tomasz Figa <redacted> Best regards, -- Tomasz Figa Samsung Poland R&D Center