Re: [PATCH 2/6] ARM: bcm476x: Add system timer

On Mon, Oct 08, 2012 at 08:43:20PM -0600, Stephen Warren wrote:

On 10/08/2012 05:50 AM, Florian Fainelli wrote:

quoted

On Sunday 07 October 2012 03:53:02 Domenico Andreoli wrote:

quoted

From: Domenico Andreoli <redacted>

System timer implementation for the BCM476x SoCs.

quoted

quoted

Index: b/arch/arm/boot/dts/bcm476x.dtsi

quoted

quoted

+		timer {
+			compatible = "brcm,bcm476x-system-timer";
+			reg = <0xba000 0x1000>;
+			interrupt-parent = <&vic0>;
+			interrupts = <4>, <11>;
+			clock-frequency = <24000000>;
+		};

This should rather be timer: timer@ba0000 for this node to be uniquely named.

I only see 1 timer node in this series, so "timer" is already unique,
isn't it?

I don't mind to add the address, this SoC actually has three timer blocks.

Dome