Re: [PATCH 1/6] ARM: bcm476x: Add infrastructure

On Mon, Oct 08, 2012 at 08:48:20PM -0600, Stephen Warren wrote:

On 10/06/2012 07:53 PM, Domenico Andreoli wrote:

quoted

BCM476x's minimal infrastructure, Kernel's great reuse.

quoted

Index: b/arch/arm/boot/dts/bcm476x.dtsi

quoted

+	chosen {
+		bootargs = "earlyprintk";
+	};

quoted

Index: b/arch/arm/configs/bcm476x_defconfig

quoted

+CONFIG_CMDLINE="root=/dev/mmcblk0p2 ro console=ttyAMA1,115200 rootwait init=/bin/bash"
+CONFIG_CMDLINE_FROM_BOOTLOADER=y

I'm not sure you need to specify a default command-line in both those
places. I would be inclined to leave out the root= option as well; it's
pretty specific to however the user's SD card was partitioned, so there
could be quite some variation there I think? Oh, especially since I
think you said there was no SD driver yet anyway?

Right, I'll drop both. Thanks.

Dome