Thread (5 messages) 5 messages, 5 authors, 2013-04-08

Re: [PATCH 10/14] media: soc-camera: support OF cameras

From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date: 2012-10-08 09:28:58
Also in: linux-media, linux-sh

Possibly related (same subject, not in this thread)

Hi Guennadi,

On 10/08/2012 10:37 AM, Guennadi Liakhovetski wrote:
quoted
quoted
  	case BUS_NOTIFY_BOUND_DRIVER:
There is no need for different handling of this event as well ?
There is. The former is entered before the sensor I2C probe method is 
called and prepares the data for probing, the latter is entered after a 
successful sensor I2C probing.
quoted
Further, there is code like:

	adap = i2c_get_adapter(icl->i2c_adapter_id);

which is clearly not going to work in OF case.
It does work. See the call to soc_camera_of_i2c_ifill() under 
BUS_NOTIFY_BIND_DRIVER above. In it

	icl->i2c_adapter_id = client->adapter->nr;
quoted
Could you clarify how it is supposed to work ?
It is not only supposed to work, it actually does work. Does the above 
explain it sufficiently?
Sorry, my fault. Somehow I didn't realize there is being passed
an I2C adapter already assigned by the I2C core. I confused it with
some static adapter nr, which would be -1 for dt case.
Apologies for wasting your time with those non-constructive questions.

--

Thanks,
Sylwester
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help