Thread (6 messages) 6 messages, 3 authors, 2012-10-30

Re: [RESEND/PATCHv3] arm: dts: omap5-evm: Add keypad support

From: Sourav <hidden>
Date: 2012-10-30 05:25:39
Also in: linux-omap, lkml

Hi Benoit,
On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote:
Hi Sourav,

On 10/29/2012 11:40 AM, Sourav Poddar wrote:
quoted
Add keypad data node in omap5-evm.

Based on I2C support patch for omap5, which has been
already posted as a different series.

Tested on omap5430 evm with 3.7-rc1 kernel.

Cc: Felipe Balbi <redacted>
Cc: Santosh Shilimkar <redacted>

Tested on omap5430 sdp with 3.7-rc1 kernel.

Signed-off-by: Sourav Poddar <redacted>
---
  arch/arm/boot/dts/omap5-evm.dts |   95 +++++++++++++++++++++++++++++++++++++++
  1 files changed, 95 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
index c663eba..b812d6d 100644
--- a/arch/arm/boot/dts/omap5-evm.dts
+++ b/arch/arm/boot/dts/omap5-evm.dts
@@ -140,3 +140,98 @@
  &mcbsp3 {
  	status = "disabled";
  };
+
+&i2c5 {
+	clock-frequency = <400000>;
+
+	smsc@38 {
+		compatible = "smscece1099";
+		reg = <0x38>;
+		clock = <0x13>;
What does that "clock" mean?
This chip supports a clock control register which is used to enable the
interface used by the chip to communicate. Here, the interface which you 
can are
SMBUS interface or BC-LINK interface.
I cannot find that in the binding documentation. BTW, did you add that
documentation in the driver patch?
Nope, I missed out on the dt binding documentation for the driver. :(

Will send a seperate patch for the bindings.
Regards,
Benoit
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help