RE: [PATCH 2/2] net: ti cpsw ethernet: set IFCTL_{A,B} bits for RMII mode
From: N, Mugunthan V <hidden>
Date: 2012-09-26 18:50:50
Also in:
netdev
quoted hunk ↗ jump to hunk
-----Original Message----- From: Daniel Mack [mailto:zonque@gmail.com] Sent: Wednesday, September 26, 2012 10:54 PM To: netdev@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org; Daniel Mack; N, Mugunthan V; Hiremath, Vaibhav; David S. Miller Subject: [PATCH 2/2] net: ti cpsw ethernet: set IFCTL_{A,B} bits for RMII mode For RMII mode operation in 100Mbps, the CPSW needs to set the IFCTL_A / IFCTL_B bits in the MACCONTROL register. Signed-off-by: Daniel Mack <zonque@gmail.com> Cc: Mugunthan V N <redacted> Cc: Vaibhav Hiremath <redacted> Cc: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/ti/cpsw.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/net/ethernet/ti/cpsw.cb/drivers/net/ethernet/ti/cpsw.c index 3d7594e..d88dbfa 100644--- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c@@ -386,6 +386,12 @@ static void _cpsw_adjust_link(struct cpsw_slave*slave, mac_control |= BIT(7); /* GIGABITEN */ if (phy->duplex) mac_control |= BIT(0); /* FULLDUPLEXEN */ + + /* set speed_in input in case RMII mode is used in >10Mbps */ + if (phy->speed > 10 && slave->slave_num < 2 && + phy->interface == PHY_INTERFACE_MODE_RMII) + mac_control |= BIT(15 + slave->slave_num);
Mac control register is separate for both the slaves and has same bit definitions, Bit 15 has to be set for 100Mbps link for RMII and RGMII Phy interface to control the RMII/RGMII gasket and in GMII this bit is Un-used by CPSW. For slave 1, Bit 16 is set with the above code which is not used control the RMII/RGMII gasket control. So it is not required to pass the Phy mode from DT. This patch has to be reworked to set Bit 15 with any Phy mode connected. The original driver present was tested with GMII (Beagle Bone A5) and RGMII (AM3358 EVM) phy , but CPSW works fine without setting this bit in RGMII phymode so this issue was not caught in testing. Regards Mugunthan V N
+
*link = true;
} else {
mac_control = 0;
--
1.7.11.4