Thread (18 messages) 18 messages, 2 authors, 2012-09-21

Re: [PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks

From: Thomas Abraham <hidden>
Date: 2012-09-20 04:38:46
Also in: linux-mmc, linux-samsung-soc

On 19 September 2012 19:10, Seungwon Jeon [off-list ref] wrote:
On Tuesday, September 18, 2012, Thomas Abraham [off-list ref] wrote:
quoted
-int dw_mci_pltfm_register(struct platform_device *pdev)
+int dw_mci_pltfm_register(struct platform_device *pdev,
+                             struct dw_mci_drv_data *drv_data)
 {
      struct dw_mci *host;
      struct resource *regs;
@@ -41,6 +42,7 @@ int dw_mci_pltfm_register(struct platform_device *pdev)
      if (host->irq < 0)
              return host->irq;

+     host->drv_data = drv_data;
      host->dev = &pdev->dev;
      host->irq_flags = 0;
      host->pdata = pdev->dev.platform_data;
@@ -48,6 +50,12 @@ int dw_mci_pltfm_register(struct platform_device *pdev)
      if (!host->regs)
              return -ENOMEM;

+     if (host->drv_data->init) {
In non-Exynos platform, host->drv_data has NULL.
Yes, sorry, I missed that.

Chris, should I fix this and send the updated patch or shall I send a
separate fix patch.

Thanks,
Thomas.

[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help