Re: [PATCH V5 1/2] of: Add generic device tree DMA helpers

On Friday 14 September 2012, Jon Hunter wrote:

Cc: Nicolas Ferre <redacted>
Cc: Benoit Cousson <redacted>
Cc: Stephen Warren <redacted>
Cc: Grant Likely <redacted>
Cc: Russell King <redacted>
Cc: Rob Herring <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Vinod Koul <redacted>
Cc: Dan Williams <redacted>
Signed-off-by: Jon Hunter <redacted>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks for all this work, looks great!

My final (tiny) comment on this:

+2. A single read-write channel with two alternative dma controllers:
+
+	dmas = <&dma1 5
+		&dma2 7
+		&dma3 2>;
+	dma-names = "rx-tx", "rx-tx", "rx-tx"

*three* alternative dma controllers, not two.

	Arnd