Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue
From: Felipe Balbi <hidden>
Date: 2012-09-04 14:35:07
Also in:
linux-omap
Hi, On Tue, Sep 04, 2012 at 02:04:15PM +0000, B, Ravi wrote:
quoted
On Fri, Aug 31, 2012 at 06:51:04PM +0530, ABRAHAM, KISHON VIJAY wrote:quoted
Hi, On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi [off-list ref] wrote:quoted
Hi, On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote:quoted
From: Santhapuri, Damodar <redacted> AM335x uses NOP transceiver driver and need to enablebuiltin PHYquoted
quoted
quoted
by writing into usb_ctrl register available in system control module register space. This is being added at musb glue driver layer untill a separate system control module driver isavailable.quoted
quoted
quoted
Signed-off-by: Ajay Kumar Gupta <redacted> Signed-off-by: Santhapuri, Damodar <redacted> Signed-off-by: Ravi Babu <redacted>Kishon, you were adding a real phy driver for OMAP's internal phy logic on one of your patches and I believe this willconflict withquoted
quoted
your changes, right ?Indeed. My final patch of that series removes some of the functions from omap_phy_internal.c (which was taken care in the phy driver).quoted
How does this look to you ? Is this at least correct ? Isuppose thequoted
quoted
correct way would be to actually have the system control module driver which we have been waiting, right ?Correct. I think once we have the system control module driver in place, we'll have everything wrt control module register writes implemented in correct way.So $SUBJECT will pretty much be thrown away once we have SCM driver, in that case it's best to wait a bit longer and apply this series once SCM driver is available and after your series too... you agree ?Felipe, I am sure there are patches in this series[0/13], which are not dependent on this patch or control module, Can we pull in those patches (all dual instances support patches)? So that I can re-work and submit again?
sure, will do, don't worry :-) -- balbi
Attachments
- signature.asc [application/pgp-signature] 836 bytes