Re: [PATCH] [v2] netdev/phy: add MDIO bus multiplexer driven by a memory-mapped device

On 08/23/2012 06:28 PM, Tabi Timur-B04825 wrote:

Stephen Warren wrote:

quoted

On 08/23/2012 01:44 PM, Timur Tabi wrote:

quoted

Add support for an MDIO bus multiplexer controlled by a simple memory-mapped
device, like an FPGA.  The device must be memory-mapped and contain only
8-bit registers (which keeps things simple).

quoted

+++ b/Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt

quoted

+	/* The FPGA node */
+	fpga: board-control@3,0 {
+		compatible = "fsl,p5020ds-fpga", "fsl,fpga-ngpixis";
+		reg = <3 0 0x30>;

Why not add the following here:

	#address-cells = <1>:
	#size-cells = <1>;
	ranges = <...>;

I forgot to add them in the txt file.  They are in the real device tree.

quoted

quoted

+
+		mdio-mux-emi2 {
+			compatible = "mdio-mux-mmioreg", "mdio-mux";
+			mdio-parent-bus = <&xmdio0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <9>; // BRDCFG1

Then, that'd have to be <9 1>;

Actually, I had #size-cells = <0>.

I think that if you have #size-cells=<0>, then you'll see the following
error message when attempting to translate the address into the parent's
address space:

prom_parse: Bad cell count for /board-control@3,0/mdio-mux-emi2

I fixed that error for cases where actual address translation isn't
required (i.e. coming up with the platform device name), but IIRC it'll
still trigger if you actually want to translate the address.