Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support
From: Rob Herring <hidden>
Date: 2012-08-23 01:42:37
Also in:
linux-arm-kernel
Possibly related (same subject, not in this thread)
- 2012-09-11 · Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support · Shawn Guo <hidden>
- 2012-09-10 · Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support · Mike Turquette <hidden>
- 2012-09-10 · Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support · Shawn Guo <hidden>
- 2012-09-07 · Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support · Mike Turquette <hidden>
- 2012-09-07 · Re: [PATCH v2 1/4] clk: add of_clk_src_onecell_get() support · Shawn Guo <hidden>
On 08/22/2012 08:36 AM, Shawn Guo wrote:
For those SoCs that have hundreds of clock outputs, their clock DT bindings could reasonably define #clock-cells as 1 and require the client device specify the index of the clock it consumes in the cell of its "clocks" phandle. Add a generic of_clk_src_onecell_get() function for this purpose. Signed-off-by: Shawn Guo <redacted> ---
I have some reservations about how generic this will end up being, but we have to start somewhere. So, for the series: Reviewed-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
quoted hunk
drivers/clk/clk.c | 14 ++++++++++++++ include/linux/clk-provider.h | 5 +++++ 2 files changed, 19 insertions(+), 0 deletions(-)diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index efdfd00..308f058 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c@@ -1582,6 +1582,20 @@ struct clk *of_clk_src_simple_get(struct of_phandle_args *clkspec, } EXPORT_SYMBOL_GPL(of_clk_src_simple_get); +struct clk *of_clk_src_onecell_get(struct of_phandle_args *clkspec, void *data) +{ + struct clk_onecell_data *clk_data = data; + unsigned int idx = clkspec->args[0]; + + if (idx >= clk_data->clk_num) { + pr_err("%s: invalid clock index %d\n", __func__, idx); + return ERR_PTR(-EINVAL); + } + + return clk_data->clks[idx]; +} +EXPORT_SYMBOL_GPL(of_clk_src_onecell_get); + /** * of_clk_add_provider() - Register a clock provider for a node * @np: Device node pointer associated with clock providerdiff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 77335fa..8fe6ec7 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h@@ -360,6 +360,11 @@ int of_clk_add_provider(struct device_node *np, void of_clk_del_provider(struct device_node *np); struct clk *of_clk_src_simple_get(struct of_phandle_args *clkspec, void *data); +struct clk_onecell_data { + struct clk **clks; + unsigned int clk_num; +}; +struct clk *of_clk_src_onecell_get(struct of_phandle_args *clkspec, void *data); const char *of_clk_get_parent_name(struct device_node *np, int index); void of_clk_init(const struct of_device_id *matches);