Thread (1 message) 1 message, 1 author, 2012-08-20

Re: [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2).

From: Timur Tabi <hidden>
Date: 2012-08-20 16:09:12

Srinivas KANDAGATLA wrote:
I agree with you to some extent,
But, Lets say a given SOC can support 5 UARTs But the board actually has
only one wired up.
Device tree for SOC has 5 entries for UART with disabled and only one
UART is enabled by board level device tree.
This is just once instance, think about SPI's, I2C, PWM's, Ethernets,
memory devices... and other IP's which might wired up for particular boards.
It's true that in this case, the devices would be marked as "disabled" in
the DTS.  Even using dtsi files won't help, because the board DTS file
will do something like this:

/include/ "uart1.dtsi"
soc: soc@e0000000 {
	uart1: uart@1000 {
		status = "disabled";
	};
};

So I understand why you would want to remove disabled nodes completely.  I
have no objection to your patch, but it's not my decision to make.  I'm
not convinced, however, that it's a real problem.  You're saving only a
10-20KB.  Is that really a problem?

-- 
Timur Tabi
Linux kernel developer at Freescale
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help