Re: [PATCH] mmc: sdhci-s3c: Add device tree support
From: Heiko Stübner <heiko@sntech.de>
Date: 2012-08-17 08:06:24
Also in:
linux-mmc, linux-samsung-soc
Hi Thomas, Am Donnerstag, 16. August 2012, 17:49:29 schrieb Thomas Abraham:
quoted hunk ↗ jump to hunk
Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks <ben-linux@fluff.org> Cc: Kukjin Kim <redacted> Cc: Chris Ball <redacted> Signed-off-by: Thomas Abraham <redacted> --- drivers/mmc/host/sdhci-s3c.c | 146 ++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 140 insertions(+), 6 deletions(-)diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index a50c205..7fcc642 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c
[...]
quoted hunk ↗ jump to hunk
@@ -737,6 +860,16 @@ static struct platform_device_idsdhci_s3c_driver_ids[] = { }; MODULE_DEVICE_TABLE(platform, sdhci_s3c_driver_ids); +#ifdef CONFIG_OF +static const struct of_device_id sdhci_s3c_dt_match[] = { + { .compatible = "samsung,s3c6410-sdhci", }, + { .compatible = "samsung,exynos4210-sdhci", + .data = &exynos4_sdhci_drv_data },
Please use the EXYNOS4_SDHCI_DRV_DATA constant here. Otherwise other Samsung platforms experimenting with dt will break. Thanks Heiko