Thread (1 message) 1 message, 1 author, 2012-08-15

Re: [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb

From: Stephen Warren <hidden>
Date: 2012-08-15 19:21:30
Also in: linux-arm-kernel, linux-serial

Possibly related (same subject, not in this thread)

On 08/08/2012 01:37 PM, Tony Prisk wrote:
quoted
On 08/07/2012 07:39 PM, Tony Prisk wrote:
quoted
Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device
tree bindings.
quoted
quoted
diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
quoted
quoted
+     np = of_find_node_by_name(NULL, "display");
+     if (!np) {
+             pr_err("%s: No display description in Device Tree\n", __func__);
+             ret = -EINVAL;
+             goto failed_free_res;
+     }
quoted
I believe that using hard-coded node names is frowned upon. Better would
be to put a phandle into the display controller's node that points at
the node representing the display, e.g.:
Will do.
I don't think this change made it into v2?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help