Re: [PATCH resend 1/2] SPI: spi-gpio: store chipselect information in private structure

On 04.08.2012 13:12, Mark Brown wrote:

On Wed, Aug 01, 2012 at 10:57:17PM +0200, Daniel Mack wrote:

quoted

The spi-gpio driver currently assumes the chipselect gpio number is
stored in ->controller_data of the device's static board information.

Applied both, thanks.  It's a bit sad that we need an explict property
for num-chipselects though.

We don't need that, and a patch to change it would be trivial.

IIRC, there was just no agreement on deriving that information
implicitly via the count of given GPIOs, and I don't know what should be
considered more important - resemblance between drivers bindings or
simplicity.

We could of course change that for all SPI master drivers at once.


Daniel

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/