RE: [PATCH v7 00/11] usb: musb: adding multi instance support

Hi Daniel

quoted

quoted

quoted

quoted

This series of patches adds,
a) Multi instances support in musb driver
b) DT support for musb_dsps glue layer
c) DT support for NOP transceiver

AM33xx and TI81xx has dual musb controller and has two usb

PHY of same type.

quoted

This patch series uses 'phandle' based API
devm_usb_get_phy_by_phandle() to get the PHY of same type. This 
API support is being added by Kishon's patch discussed at [1]

The series applies to linux-omap (master branch)
	+ Vaibhav baseport patches on his tree at [3]
	+ Kishon's multi phy patches on Felipe's branch 'xceiv'
	+ Kishon's patch on phandle at [1]
	+ AM33xx musb glue compile and bugfix patches at [4],

[5], [6] and [7]

quoted

	+ Damodar's recent patch at [2]

and have been tested on Beaglebone board.

Have you applied the above patches before applying these patches.

Somehow, I was missing some of Ajay's patches. I resolved that, and 
now the series applied.

However, I needed to add a phandle "usb0-phy = <&usb0_phy>" to the 
usb_otg_hs DTSI block, otherwise devm_usb_get_phy_by_phandle() in 
drivers/usb/musb/musb_dsps.c would fail. Is that correct? I 

can't seem 

quoted

to find that in your patches.

It's getting done in patch 11/11.

Refer patch 11/11 available at http://marc.info/?l=linux-usb&m=134390988804627&w=2 

Ravi Babu

quoted

With this addition, I see the following:

[    1.782180] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host)
[    1.809966] musb-hdrc musb-hdrc.0: MUSB HDRC host driver
[    1.819068] musb-hdrc musb-hdrc.0: new USB bus 

registered, assigned

quoted

bus number 1
[    1.827970] usb usb1: New USB device found, idVendor=1d6b,
idProduct=0002
[    1.835184] usb usb1: New USB device strings: Mfr=3, Product=2,
SerialNumber=1
[    1.842818] usb usb1: Product: MUSB HDRC host driver
[    1.848031] usb usb1: Manufacturer: Linux
3.6.0-rc1-00038-g8a1ec8f-dirty musb-hcd
[    1.855933] usb usb1: SerialNumber: musb-hdrc.0
[    1.866913] hub 1-0:1.0: USB hub found
[    1.871192] hub 1-0:1.0: 1 port detected
[    1.878106] musb-hdrc musb-hdrc.0: USB Host mode controller at
d08c0000 using PIO, IRQ 18	

... but no USB functions. Also, every two seconds, the following 
message is
printed:

[   11.036608] musb_bus_suspend 2308: trying to suspend as 

a_wait_vrise

quoted

while active
[   13.044811] musb_bus_suspend 2308: trying to suspend as 

a_wait_vrise

quoted

while active
[   15.052196] musb_bus_suspend 2308: trying to suspend as 

a_wait_vrise

quoted

while active

Do you see them even when you connect a device to port?

Ajay

quoted

Anything obvious that I'm missing?


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe 

linux-usb" 

quoted

in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More 

majordomo 

quoted

info at http://vger.kernel.org/majordomo-info.html

--------------------------------------------------------------
---------------------
This email message is for the sole use of the intended 
recipient(s) and may contain confidential information.  Any 
unauthorized review, use, disclosure or distribution is 
prohibited.  If you are not the intended recipient, please 
contact the sender by reply email and destroy all copies of 
the original message.
--------------------------------------------------------------
---------------------
--

To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html