Re: [PATCH 1/2] net: davinci_mdio: enable and disable clock

On 02.08.2012 21:53, Russell King - ARM Linux wrote:

On Thu, Aug 02, 2012 at 09:43:35PM +0200, Daniel Mack wrote:

quoted

Make the driver control the device clocks. Appearantly, the Davinci
platform probes this driver with the clock all powered up, but on OMAP,
this isn't the case.

Hmm, this looks like it could do with improvement, especially as we're
moving everything over to a common clk API.

1. This driver could do with clk_prepare()/clk_unprepare() calls.

Ok, done.

2. This driver should not be making the assumption that NULL means
   it can avoid clk_* calls.  It should instead be using
	if (!IS_ERR(clk))

Well spotted. Amended patch below.


Thanks,
Daniel