Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote:

On Wed, Aug 22, 2012 at 03:18:45PM +0800, Dong Aisheng wrote:

quoted

From: Dong Aisheng <redacted>

Using standard imx syscon API to access anatop register.

Acked-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

Thanks

With the conversion to regmap it'd also be good to convert the driver to
use the regmap helper functions for enable and voltage operations if
possible.

The anatop-regulator driver only implements set_voltage_sel/get_voltage_sel
which i have already converted, what do you mean others like
'for enable and voltage operations' i should also convert?

Regards
Dong Aisheng