Re: [PATCH 2/8 v2] ARM: EXYNOS5: Add machine data for USB 2.0
From: Vivek Gautam <hidden>
Date: 2012-07-28 16:05:11
Also in:
linux-arm-kernel, linux-samsung-soc
On Thu, Jul 26, 2012 at 8:24 PM, Arnd Bergmann [off-list ref] wrote:
On Saturday 21 July 2012, Vivek Gautam wrote:quoted
From: Ajay Kumar <redacted> This patch adds address mapping of USB 2.0 PHY for exynos5 Signed-off-by: Ajay Kumar <redacted> Signed-off-by: Vivek Gautam <redacted> --- arch/arm/mach-exynos/common.c | 5 +++++ arch/arm/mach-exynos/include/mach/map.h | 2 ++ 2 files changed, 7 insertions(+), 0 deletions(-)diff --git a/arch/arm/mach-exynos/common.cb/arch/arm/mach-exynos/common.cquoted
index 4eb39cd..92d5e61 100644--- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos/common.c@@ -275,6 +275,11 @@ static struct map_desc exynos5_iodesc[] __initdata= {quoted
.pfn = __phys_to_pfn(EXYNOS5_PA_GIC_DIST), .length = SZ_4K, .type = MT_DEVICE, + }, { + .virtual = (unsigned long)S3C_VA_USB_HSPHY, + .pfn = __phys_to_pfn(EXYNOS5_PA_USB_PHY), + .length = SZ_4K, + .type = MT_DEVICE, }, };Can you pleae explain why this is done in the changelog? We try hard to do such mappings from the device driver instead, so I'm surprised that this is necessary fo rthe USB phy.
We are doing the mapping for device address in the driver, but this memory mapping for USB PHY registers that need to be programmed by the software is done here. This is similar to what we see for exynos4 also. Is it something that i can still change? Please suggest.
Arnd
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discussBest regards Vivek