Thread (1 message) 1 message, 1 author, 2012-07-20

Re: [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller

From: Arnd Bergmann <hidden>
Date: 2012-07-20 22:10:28
Also in: linux-arm-kernel

On Friday 20 July 2012, Tony Prisk wrote:
Add support for a generic non-pci UHCI companion controller.
Existing board files for arch-vt8500 updated to include UHCI
support.

Signed-off-by: Tony Prisk <redacted>
Looks almost good, but 

* please add a binding document
* cc the maintainers and usb mailing list
* the "of-uhci" string does not seem appropriate:
+static const struct of_device_id platform_uhci_ids[] = {
+	{ .compatible = "of-uhci", },
+	{}
+};
The of- part is clearly meaningless in the binding that is about of
devices. Using usb-uhci would be more appropriate I think, but maybe
someone can come up with an even better name. Which consortium
or company created uhci?

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help