Re: [PATCH] of: require a match on all fields of of_device_id
From: Tabi Timur-B04825 <hidden>
Date: 2012-07-18 01:57:53
Also in:
linuxppc-dev
Possibly related (same subject, not in this thread)
- 2012-07-23 · Re: [PATCH] of: require a match on all fields of of_device_id · Scott Wood <hidden>
- 2012-07-23 · Re: [PATCH] of: require a match on all fields of of_device_id · Rob Herring <hidden>
- 2012-07-18 · Re: [PATCH] of: require a match on all fields of of_device_id · Scott Wood <hidden>
- 2012-07-18 · Re: [PATCH] of: require a match on all fields of of_device_id · Rob Herring <hidden>
- 2012-07-18 · [PATCH] of: require a match on all fields of of_device_id · Scott Wood <hidden>
On Tue, Jul 17, 2012 at 8:11 PM, Scott Wood [off-list ref] wrote:
Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible
property first") breaks the gianfar ethernet driver found on various
Freescale PPC chips.
There are, for unfortunate historical reasons, two nodes with a
compatible of "gianfar".
Would it be worth updating the binding for the two nodes to make the
compatible property different? We could do something like this:
ethernet@24000 {
reg = <0x24000 0x1000>;
compatible = "fsl,gianfar-eth", "gianfar";
...
};
(and something similar for MDIO nodes)
and update all the drivers to look for both strings. After a few
years, we can delete "gianfar".
--
Timur Tabi
Linux kernel developer at Freescale