Re: [PATCH 2/5] fdtput: Prepare to support multiple operations

Hi David,

On Thu, Jul 12, 2012 at 2:37 PM, David Gibson
[off-list ref] wrote:

On Tue, Jul 10, 2012 at 05:56:45AM -0700, Simon Glass wrote:

quoted

We want to add new options to this tool. In preparation for this, add
the concept of a current operation.

Signed-off-by: Simon Glass <redacted>
---
 fdtput.c |   37 ++++++++++++++++++++++++++-----------
 1 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/fdtput.c b/fdtput.c
index 244d1f1..eceb7f2 100644
--- a/fdtput.c
+++ b/fdtput.c

@@ -28,7 +28,13 @@

 #include "util.h"

+/* These are the operations we support */
+enum operation_t {

This isn't quite usual convention xxx_t usually indicates a typedef

OK I will fix it, and also update the help messages a little in two of
the patches (something I just noticed).

Regards,
Simon

--
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson