Re: [PATCH REPOST] Add test for re-defining an identical label
From: David Gibson <hidden>
Date: 2012-07-08 23:42:19
On Sun, Jul 08, 2012 at 01:44:04PM -0500, Jon Loeliger wrote:
quoted
On Tue, Jul 03, 2012 at 02:09:30PM -0600, Stephen Warren wrote:quoted
From: Stephen Warren <redacted> When merging one device tree over the top of a previous tree, it is possible to define a duplicate label that has the same name and points to the same property or node. This is currently allowed by the duplicate label checking code. However, alternative duplicate label checking algorithms might not allow this. Add an explicit test to ensure this capability is maintained.Sorry, I've been on leave and haven't really had brainspace to think about this. I think you're right though, whatever else we do with stuff we do want to allow redefinition of labels as long as they attach to the same thing (i.e. same path, and property within that path when applicable). Labels within property values do get curly if that property is altered, but that doesn't directly affect this test.quoted
Signed-off-by: Stephen Warren <redacted>Acked-by: David Gibson <redacted>Applied.
Hrm, apparently not pushed out, though. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson