Thread (7 messages) 7 messages, 3 authors, 2012-07-27

Re: [PATCH] mfd: add MAX8907 core driver

From: Laxman Dewangan <ldewangan@nvidia.com>
Date: 2012-07-27 06:47:24
Also in: lkml

On Friday 27 July 2012 01:10 AM, Stephen Warren wrote:
From: Gyungoh Yoo<redacted>
+static int max8907_irq_set_wake(struct irq_data *data, unsigned int on)
+{
+       /* Everything happens in max8907_irq_sync_unlock */
+
Probably you need to call the wake_enable of irq which goes to the cpu here.

+       if (device_may_wakeup(chip->dev))
+               enable_irq_wake(i2c->irq);
+       else
+               disable_irq(i2c->irq);
I think lets sub devices decide the wakeups rather than it is done by 
the core.

+       max8907->i2c_rtc = i2c_new_dummy(i2c->adapter, MAX8907_RTC_I2C_ADDR);
+       if (!max8907->i2c_rtc) {
+               ret = -ENOMEM;
+               goto err_dummy_rtc;
+       }
+       i2c_set_clientdata(max8907->i2c_rtc, max8907);
+       max8907->regmap_rtc = devm_regmap_init_i2c(i2c,
+&max8907_regmap_rtc_config);
the argiment should be  max8907->i2c_rtc rather than i2c here.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help