Re: [patch] driver-core: dev_to_node() should handle NULL pointers
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2012-07-20 15:00:49
Also in:
kernel-janitors, lkml
On Fri, Jul 20, 2012 at 09:56:23AM +0300, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
What prompted this patch is that in dma_pool_create() we call dev_to_node() before checking whether "dev" is NULL. It looks like there are places which call dma_pool_create() with a NULL pointer. An example is in drivers/usb/gadget/amd5536udc.c. Signed-off-by: Dan Carpenter <redacted> --- Static checker fix.diff --git a/include/linux/device.h b/include/linux/device.h index aa7b3b4..c80e7a8d 100644 --- a/include/linux/device.h +++ b/include/linux/device.h@@ -714,7 +714,9 @@ int dev_set_name(struct device *dev, const char *name, ...); #ifdef CONFIG_NUMA static inline int dev_to_node(struct device *dev) { - return dev->numa_node; + if (dev) + return dev->numa_node; + return -1;
What happens if this function returns -1? Can the callers properly handle this? thanks, greg k-h