Thread (6 messages) read the whole thread 6 messages, 2 authors, 2012-07-16

Re: [PATCH] mfd: add tps65910 32-kHz-crystal-input init

From: Samuel Ortiz <hidden>
Date: 2012-07-16 13:44:04
Also in: lkml

Hi Johan,

On Wed, Jul 11, 2012 at 03:44:33PM +0200, Johan Hovold wrote:
Replace tps65910_misc_init with a dedicated init function for the
32-kHz-crystal input.

Signed-off-by: Johan Hovold <redacted>
---

Hi Samuel,

How about something like this? My thought with misc_init was that it could be
extended should more simple initialisation like for the ck32k_xtal need to be
done, but perhaps it's cleaner to stick with dedicated init functions
through-out. At least for now.
Yes, it's clearer, at least to me.
I applied this patch, thanks for following up.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help