Thread (35 messages) 35 messages, 4 authors, 2012-07-10

RE: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

From: Venu Byravarasu <hidden>
Date: 2012-07-10 06:03:34
Also in: linux-arm-kernel, linux-omap, lkml

quoted
+
+#ifdef CONFIG_PM
Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? 
quoted
+
+static int omap_usb2_runtime_suspend(struct device *dev)
+{
+	struct platform_device	*pdev = to_platform_device(dev);
+	struct omap_usb	*phy = platform_get_drvdata(pdev);
+
quoted
+static int __init usb2_omap_init(void)
+{
+	return platform_driver_register(&omap_usb2_driver);
+}
+arch_initcall(usb2_omap_init);
+
+static void __exit usb2_omap_exit(void)
+{
+	platform_driver_unregister(&omap_usb2_driver);
+}
+module_exit(usb2_omap_exit);
+
Do you really need arch_initcall here?
If not, then you can replace above two function calls with module_platform_driver().
quoted
+MODULE_ALIAS("platform: omap_usb2");
+MODULE_AUTHOR("Texas Instruments Inc.");
+MODULE_DESCRIPTION("OMAP USB2 PHY DRIVER");
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help