[PATCH v8 01/14] usb: chipidea: remove unneeded NULL check
From: Richard Zhao <hidden>
Date: 2012-06-28 03:37:18
Also in:
linux-arm-kernel
Subsystem:
chipidea usb high speed dual role controller, the rest, usb subsystem · Maintainers:
Peter Chen, Linus Torvalds, Greg Kroah-Hartman
Possibly related (same subject, not in this thread)
- 2012-06-29 · [PATCH v8 01/14] usb: chipidea: remove unneeded NULL check · Richard Zhao <hidden>
From: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> As reported by Dan Carpenter, there is a NULL check in udc_start() that follows a dereference of the pointer that's being checked. However, at that point udc pointer shouldn't ever be NULL and if it is, the dereference should cause an oops. Signed-off-by: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Reported-by: Dan Carpenter <redacted> Acked-by: Felipe Balbi <redacted> Signed-off-by: Richard Zhao <redacted> Acked-by: Marek Vasut <redacted> --- drivers/usb/chipidea/udc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 51f9694..cdb9212 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c@@ -1647,9 +1647,6 @@ static int udc_start(struct ci13xxx *udc) struct device *dev = udc->dev; int retval = 0; - if (!udc) - return -EINVAL;