Re: [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

On Tue, Jun 26, 2012 at 02:43:11PM -0700, Greg KH wrote:

On Mon, Jun 25, 2012 at 02:56:18PM +0800, Richard Zhao wrote:

quoted

From: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

As reported by Dan Carpenter, there is a NULL check in udc_start() that
follows a dereference of the pointer that's being checked. However, at
that point udc pointer shouldn't ever be NULL and if it is, the dereference
should cause an oops.

Signed-off-by: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Reported-by: Dan Carpenter <redacted>
Acked-by: Felipe Balbi <redacted>
---
 drivers/usb/chipidea/udc.c |    3 ---
 1 file changed, 3 deletions(-)

First comment, you send a bunch of patches, yet you didn't sign off on
some of them, why?  If you are forwarding on patches, please sign off
showing you have reviewed them (so you can be on the path-of-blame if
there is a problem...)

You're right :)

There has been some discussion on some of these patches, so I'm guessing
we need a v8 set of this series at the least?

Yes.

Thanks
Richard

thanks,

greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html