Dear Shawn Guo,

On Mon, Jun 25, 2012 at 06:01:22PM +0200, Marek Vasut wrote:

quoted

Dear Shawn Guo,

quoted

On Sat, Jun 23, 2012 at 04:15:18AM +0200, Marek Vasut wrote:

quoted

So is there any particular reason why this wasn't applied?

Let me remind Artem by resending the patch tomorrow.

Actually ... the SPI does have the heuristics to probe this chip without
the patch. But there was this discussion about them eventually being
removed. That was a point raised by you I think. Is that still valid?

That was a point raised by Grant.  IIRC, the reason I made the patch
is my system does not probe the device without the patch.  I can
retest, and if it's true that the patch is not necessarily needed,
I will probably let it be.

116                         ssp2: ssp@80014000 {
117                                 #address-cells = <1>;
118                                 #size-cells = <0>;
119                                 compatible = "fsl,imx28-spi";
120                                 pinctrl-names = "default";
121                                 pinctrl-0 = <&spi2_pins_a>;
122                                 status = "okay";
123 
124                                 flash: m25p80@0 {
125                                         #address-cells = <1>;
126                                         #size-cells = <1>;
127                                         compatible = "m25p80";
128                                         spi-max-frequency = <25000000>;
129                                         reg = <0>;
130                                 };
131                         };

I use this + my SPI patches I submitted recently.

Best regards,
Marek Vasut