Re: [PATCH v6 12/14] usb: chipidea: permit driver bindings pass phy pointer

On Thu, Jun 21, 2012 at 09:18:22AM +0200, Marc Kleine-Budde wrote:

On 06/21/2012 08:41 AM, Richard Zhao wrote:

quoted

Sometimes, the driver bindings may know what phy they use.
For example, when using device tree, the usb controller may have a
phandler pointing to usb phy.

Signed-off-by: Richard Zhao <redacted>
Reviewed-by: Marek Vasut <redacted>
Acked-by: Felipe Balbi <redacted>
Tested-by: Subodh Nijsure <snijsure-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>

[...]

quoted

--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c

@@ -1684,7 +1684,8 @@ static int udc_start(struct ci13xxx *ci)
 
 	ci->gadget.ep0 = &ci->ep0in->ep;
 
-	ci->transceiver = usb_get_transceiver();
+	if (ci->global_phy) {

                           ^^^

This doesn't compile, closing curly brackets are missing.

Nice catch. 

Thanks
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html