Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support

On Wed, Jun 13, 2012 at 08:21:08PM +0000, Arnd Bergmann wrote:

On Wednesday 13 June 2012, Thierry Reding wrote:

quoted

                pci@80000000 {
                        reg = <0x80000000 0x00001000>;
                        status = "disabled";

                        #address-cells = <3>;
                        #size-cells = <2>;

                        ranges = <0x80400000 0x80400000 0x00008000   /* I/O */
                                  0x90000000 0x90000000 0x08000000   /* non-prefetchable memory */
                                  0xa0000000 0xa0000000 0x08000000>; /* prefetchable memory */

                        nvidia,ctrl-offset = <0x0>;
                        nvidia,num-lanes = <2>;
                };

I believe you will need an "interrupt-map" property here, to map the host
interrupts to the INTA-INTD lines of the attached devices.

Legacy interrupts are something I cannot test at all because I have no
hardware that supports them.

I'm not sure whether we want to have a device_type="pciex" property here.
powerpc and sparc seem to use that information, to distinguish a pcie
bus from pci or cardbus.

That'd be rather useless information given that the Tegra is unlikely to
support either PCI or CardBus at some point.

Thierry