Re: [Patch v5 05/13] usb: otg: add basic mxs phy driver support

On Wed, Jun 13, 2012 at 11:56:15PM +0200, Marek Vasut wrote:

Dear Sascha Hauer,

quoted

This message is rather useless. It is really not expected for kzalloc
to fail. If it fails here you really have problems elsewhere and this
message won't help you debugging it.

It's not useless, but it'll hardly ever be displayed if you run out of memory so 
badly this kzalloc() will fail.

If you run out of memory while allocating a few bytes it's really
not interesting where exactly this happens. The message won't give
you any hint where you can fix this problem. Also, if you bail out
of a drivers probe function with -ENOMEM you will have a message
in the log anyway.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html