Re: [Patch v5 03/13] USB: notify phy when root hub port connect change
From: Alan Stern <hidden>
Date: 2012-06-13 18:25:17
Also in:
linux-arm-kernel
On Wed, 13 Jun 2012, Richard Zhao wrote:
quoted hunk
Phy may need to change settings when port connect change. Signed-off-by: Richard Zhao <redacted> --- drivers/usb/core/hub.c | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 04fb834..e1a6d31 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c@@ -20,6 +20,7 @@ #include <linux/usb.h> #include <linux/usbdevice_fs.h> #include <linux/usb/hcd.h> +#include <linux/usb/otg.h> #include <linux/usb/quirks.h> #include <linux/kthread.h> #include <linux/mutex.h>@@ -4034,6 +4035,13 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1, } } + if (unlikely(hcd->phy && !hdev->level)) {
This is okay, but it's more common to test for root hubs with "!hdev->parent".
+ if (portstatus & USB_PORT_STAT_CONNECTION) + usb_phy_notify_connect(hcd->phy, port1); + else + usb_phy_notify_disconnect(hcd->phy, port1); + } + /* Return now if debouncing failed or nothing is connected or * the device was "removed". */
Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html