Thread (1 message) 1 message, 1 author, 2012-06-12

Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

From: Thierry Reding <hidden>
Date: 2012-06-12 06:13:31
Also in: linux-arm-kernel, linux-pci, linux-tegra

* Stephen Warren wrote:
On 06/11/2012 09:05 AM, Thierry Reding wrote:
quoted
Device tree support for the TPS6586x PMU used on Harmony has recently
been added. This commit adds the required device tree nodes to probe the
PMU from the device tree.
quoted
diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts
quoted
+		tps6586x@34 {
+			compatible = "ti,tps6586x";
+			reg = <0x34>;
+			interrupts = <0 88 0x4>;
+
+			#gpio-cells = <2>;
+			gpio-controller;
+
+			regulators {
Per the TPS65911 discussion on regulator bindings, this node should have:

	#address-cells = <1>;
	#size-cells = <0>;
quoted
+				sm0 {
Each of these nodes should be named regulator@0, regulator@1, etc.

Within each of these nodes, you need a matching reg property.

	reg = <0>;

and something to identify which regulator within the chip this node
configurations, although I don't think we've reached a final decision on
the property name.

See the the following for details:

http://www.spinics.net/lists/linux-tegra/msg05577.html
Okay, I'll monitor that discussion and see what you end up with. I guess I'll
have to update the tps6586x binding when that decision has been reached and
add a patch to this series.

Thierry

Attachments

  • (unnamed) [application/pgp-signature] 198 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help