Re: [PATCH RESEND] of: add const to struct of_device_id.data
From: Uwe Kleine-König <hidden>
Date: 2012-06-22 05:56:18
Also in:
lkml
On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote:
Drivers should never need to modify the data of a device id. So it can be const which in turn allows more consts in the driver. Signed-off-by: Uwe Kleine-König <redacted> --- (Cc += lkml + Grant) Hello, this might introduce warnings in drivers that access the data member without using const, so this is definitly merge window material if it is considered at all.
ping Best regards Uwe
quoted hunk ↗ jump to hunk
include/linux/mod_devicetable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h index 501da4c..183f411 100644 --- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h@@ -222,7 +222,7 @@ struct of_device_id char type[32]; char compatible[128]; #ifdef __KERNEL__ - void *data; + const void *data; #else kernel_ulong_t data; #endif-- 1.7.10 -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |