Thread (9 messages) 9 messages, 3 authors, 2012-06-20

Re: [PATCH v2 5/5] sched: cpu_power: enable ARCH_POWER

From: Peter Zijlstra <hidden>
Date: 2012-06-20 09:19:59
Also in: linux-arm-kernel, lkml

On Wed, 2012-06-20 at 11:11 +0200, Vincent Guittot wrote:
On 19 June 2012 11:01, Yong Zhang [off-list ref] wrote:
quoted
On Tue, Jun 19, 2012 at 10:28:56AM +0200, Vincent Guittot wrote:
quoted
Heteregeneous ARM platform uses arch_scale_freq_power function
to reflect the relative capacity of each core

Signed-off-by: Vincent Guittot <redacted>
---
 kernel/sched/features.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/features.h b/kernel/sched/features.h
index de00a48..d98ae90 100644
--- a/kernel/sched/features.h
+++ b/kernel/sched/features.h
@@ -42,7 +42,7 @@ SCHED_FEAT(CACHE_HOT_BUDDY, true)
 /*
  * Use arch dependent cpu power functions
  */
-SCHED_FEAT(ARCH_POWER, false)
+SCHED_FEAT(ARCH_POWER, true)
Hmmm...seems we can remove this knob completely.
Peter,

Do you prefer to keep it or remove it completely ?
I prefer to keep it, the 'we can remove it' is true for all feature
bits, they should never be twiddled in normal circumstances, its a debug
feature. As such it makes sense to allow disabling the arch cpu-power
fiddling.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help