Re: [PATCH v4 1/7] ARM: davinci, intc: Add irq domain support

Hello Grant,

Am 26.05.2012 08:03, Grant Likely wrote:

On Tue, 22 May 2012 15:55:14 +0200, Heiko Schocher[off-list ref]  wrote:

quoted

Signed-off-by: Heiko Schocher<redacted>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Sekhar Nori<redacted>
Cc: Wolfgang Denk<redacted>
Cc: Sergei Shtylyov<redacted>

Hi Heiko,

Earlier today I commented (again) on the previous version of this
patch.  Sorry about that.  I'm happy with the direction this series is

No problem!

going.  Here's one more comments.

Thanks!

quoted

diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
index f83152d..bb52807 100644
--- a/arch/arm/mach-davinci/cp_intc.c
+++ b/arch/arm/mach-davinci/cp_intc.c

@@ -9,8 +9,10 @@
   * kind, whether express or implied.
   */

+#include<linux/export.h>
  #include<linux/init.h>
  #include<linux/irq.h>
+#include<linux/irqdomain.h>
  #include<linux/io.h>

  #include<mach/common.h>

@@ -99,18 +101,37 @@ static struct irq_chip cp_intc_irq_chip = {
  	.irq_set_wake	= cp_intc_set_wake,
  };

All of the irq_chip hooks need to be switched from using d->irq to
d->hwirq for the hardware irq number.  That sets up to driver to
switch to using dynamic allocation of irq_descs.

Ok, try to work this in...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany