Re: bootloader support for DTB on x86
From: Sebastian Andrzej Siewior <hidden>
Date: 2012-05-22 19:51:07
Subsystem:
the rest, x86 architecture (32-bit and 64-bit) · Maintainers:
Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
Possibly related (same subject, not in this thread)
- 2012-07-10 · Re: bootloader support for DTB on x86 · Thierry Reding <hidden>
- 2012-07-10 · Re: bootloader support for DTB on x86 · Simon Glass <hidden>
- 2012-05-22 · Re: bootloader support for DTB on x86 · H. Peter Anvin <hidden>
- 2012-05-22 · Re: bootloader support for DTB on x86 · Dirk Brandewie <hidden>
- 2012-05-22 · bootloader support for DTB on x86 · Thierry Reding <hidden>
* Thierry Reding | 2012-05-22 14:56:22 [+0200]:
Hi,
Hi,
I was looking at booting an x86-based platform using DT. However I wasn't able to find a bootloader that supports this. There also doesn't seem to be a method to append the DTB to the zImage (which I wouldn't want to use anyway). Does anybody know of a bootloader that supports this?
None that I am aware of.
I'm currently using syslinux (specifically extlinux) and was looking at perhaps adding the support myself based on the information given in Documentation/x86/boot.txt. However I'm not overly familiar with syslinux code and this could prove more difficult than I anticipate.
It should not be that difficult. - Look how the initrd is loaded. Use the same technique to load the dtb blob. - Allocate another memory block for setup_data. You need one entry of type SETUP_DTB pointing to the dtb. If I remember correctly, the setup_data is thrown away by kernel and the dtb blob itself is relocated to some place safe. - You may need to set hardware_subarch to some similar to X86_SUBARCH_CE4100. I mean you *may* need your own subarch value but you can most likely reuse most of the functions that ce4100 is using. The PCI bus and UART is broken is a special way, everything else is generic. Since we don't have ACPI/SFI,⊠we need something to find HPET, IO-APIC, irq routing,âŠ
The only x86 platforms that use DT seem to be OLPC and CE4100 and according to the web the OLPC has a complete OF implementation. Does anyone know which bootloader the CE4100 uses?
It jumps in the end to redboot which then loads the kernel. In the early days I had this patch make to sure the setup_data thingy works. So with this it should be easy to add the support to redboot/grub/isolinux/⊠From: Sebastian Andrzej Siewior <redacted> Subject: [PATCH ] x86/dtb: add bzImage support this adds two new targets: - arch/x86/boot/$dt.dtb a convience target which just calls dtc on the $dtb which lives in arch/x86/boot/dts/$dt.dts - bzImage.$dt embeds the device tree in the bzImage loader. The dtb will be passed to the kernel via setup_data if there is no dtb included. The memory location of the dtb will be before the initrd if one is available. If not it will placed at "memory size" or 128MiB depends which one is less. The upper limit is used a guess to ensure that it remains in lowmem. On a system with 1GiB the lowmem is around ~880MiB. The exact value depends on a few CONFIG_ swithes and is determined at run time. It can be additionaly increased or decreased via kernel parameters like memmap or vmalloc. So instead of parsing every piece of information we assume that nobody runs a kernel with only the first 100MiB mapped. Signed-off-by: Sebastian Andrzej Siewior <redacted> --- arch/x86/Makefile | 6 +++ arch/x86/boot/Makefile | 29 ++++++++++++++-- arch/x86/boot/compressed/Makefile | 25 ++++++++++++-- arch/x86/boot/compressed/misc.c | 60 +++++++++++++++++++++++++++++++- arch/x86/boot/compressed/vmlinux.lds.S | 7 ++++ 5 files changed, 120 insertions(+), 7 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index e8c8881..50dffd8 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile@@ -161,6 +161,9 @@ endif $(Q)mkdir -p $(objtree)/arch/$(UTS_MACHINE)/boot $(Q)ln -fsn ../../x86/boot/bzImage $(objtree)/arch/$(UTS_MACHINE)/boot/$@ +bzImage.%: vmlinux + $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ + $(BOOT_TARGETS): vmlinux $(Q)$(MAKE) $(build)=$(boot) $@
@@ -177,6 +180,9 @@ archclean: $(Q)rm -rf $(objtree)/arch/x86_64 $(Q)$(MAKE) $(clean)=$(boot) +%.dtb: + $(Q)$(MAKE) $(build)=$(boot) $@ + define archhelp echo '* bzImage - Compressed kernel image (arch/x86/boot/bzImage)' echo ' install - Install kernel using'
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index f7cb086..a7651f2 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile@@ -72,20 +72,30 @@ KBUILD_CFLAGS += $(call cc-option, -m32) KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__ GCOV_PROFILE := n -$(obj)/bzImage: asflags-y := $(SVGA_MODE) +$(obj)/bzImage $(obj)/bzImage.%: asflags-y := $(SVGA_MODE) quiet_cmd_image = BUILD $@ -cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \ +cmd_image = $(obj)/tools/build $(obj)/setup.bin $2 \ $(ROOT_DEV) > $@ $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build FORCE - $(call if_changed,image) + $(call if_changed,image, $(obj)/vmlinux.bin) + @echo 'Kernel: $@ is ready' ' (#'`cat .version`')' + +$(obj)/bzImage.%: $(obj)/setup.bin $(obj)/vmlinux.bin.% $(obj)/tools/build FORCE + $(call if_changed,image,$(obj)/vmlinux.bin.$*) @echo 'Kernel: $@ is ready' ' (#'`cat .version`')' OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S $(obj)/vmlinux.bin: $(obj)/compressed/vmlinux FORCE $(call if_changed,objcopy) +quiet_cmd_objcopybin = OBJCOPY $@ + cmd_objcopybin = $(OBJCOPY) $(OBJCOPYFLAGS) -O binary -R .note -R .comment -S $< $@ + +$(obj)/vmlinux.bin.%: $(obj)/compressed/vmlinux.dtb.% FORCE + $(call if_changed,objcopybin) + SETUP_OBJS = $(addprefix $(obj)/,$(setup-y)) sed-voffset := -e 's/^\([0-9a-fA-F]*\) . \(_text\|_end\)$$/\#define VO_\2 0x\1/p'
@@ -121,6 +131,19 @@ $(obj)/setup.bin: $(obj)/setup.elf FORCE $(obj)/compressed/vmlinux: FORCE $(Q)$(MAKE) $(build)=$(obj)/compressed $@ +$(obj)/compressed/vmlinux.dtb.%: FORCE + $(Q)$(MAKE) $(build)=$(obj)/compressed $@ + +dtstree := $(srctree)/$(src)/dts +DTC = $(objtree)/scripts/dtc/dtc + +quiet_cmd_dtc = DTC $@ + cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 -p 1024 $(dtstree)/$*.dts + +# Rule to build device tree blobs +$(obj)/%.dtb: $(dtstree)/%.dts FORCE + $(call if_changed,dtc) + # Set this if you want to pass append arguments to the # bzdisk/fdimage/isoimage kernel FDARGS =
diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index 0c22955..4137939 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile@@ -18,15 +18,34 @@ KBUILD_CFLAGS += $(call cc-option,-fno-stack-protector) KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__ GCOV_PROFILE := n -LDFLAGS := -m elf_$(UTS_MACHINE) -LDFLAGS_vmlinux := -T +LDFLAGS := -m elf_$(UTS_MACHINE) -T hostprogs-y := mkpiggy -$(obj)/vmlinux: $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o $(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o $(obj)/piggy.o FORCE +VMLINUX_DEP := $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o $(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o $(obj)/piggy.o + +$(obj)/vmlinux: $(VMLINUX_DEP) FORCE + $(call if_changed,ld) + @: + +dtstree := $(srctree)/arch/x86/boot/dts +DTC = $(objtree)/scripts/dtc/dtc + +quiet_cmd_dtc = DTC $@ + cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 -p 1024 $(dtstree)/$*.dts + +$(obj)/%.dtb: $(dtstree)/%.dts + $(call if_changed,dtc) + +$(obj)/%.dtb.S: $(obj)/%.dtb + @echo '.section .data..dtb,"a"' > $@ + @echo '.incbin "$<" ' >> $@ + +$(obj)/vmlinux.dtb.%: $(VMLINUX_DEP) $(obj)/%.dtb.o FORCE $(call if_changed,ld) @: +targets += vmlinux.dtb.% OBJCOPYFLAGS_vmlinux.bin := -R .comment -S $(obj)/vmlinux.bin: vmlinux FORCE $(call if_changed,objcopy)
diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index 8f7bef8..ebd6901 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c@@ -101,7 +101,8 @@ #undef memcpy #define memzero(s, n) memset((s), 0, (n)) - +extern char _dtb_end[]; +extern char _dtb_start[]; static void error(char *m); /*
@@ -302,6 +303,40 @@ static void parse_elf(void *output) } } +static u64 attach_initdata(u64 old_sd, void *dest, void *data, unsigned int len, + unsigned int type) +{ + struct setup_data *sd = dest; + + sd->next = old_sd; + sd->type = type; + sd->len = len; + memcpy(&sd->data[0], data, len); + return (u64) (u32) sd; +} + +static u64 attach_dtb(u64 old_sd, void *dest, void *data, unsigned int len) +{ + return attach_initdata(old_sd, dest, data, len, SETUP_DTB); +} + +static int dtb_passed(u64 setup_data) +{ + int ret = 0; + + while (setup_data) { + struct setup_data *sdata; + + sdata = (void *)(u32)setup_data; + if (sdata->type == SETUP_DTB) { + ret = 1; + break; + } + setup_data = sdata->next; + } + return ret; +} + asmlinkage void decompress_kernel(void *rmode, memptr heap, unsigned char *input_data, unsigned long input_len,
@@ -350,6 +385,29 @@ asmlinkage void decompress_kernel(void *rmode, memptr heap, putstr("\nDecompressing Linux... "); decompress(input_data, input_len, NULL, NULL, output, NULL, error); parse_elf(output); + if (_dtb_end > _dtb_start && !dtb_passed(real_mode->hdr.setup_data)) { + u32 k_dtb; + + if (real_mode->hdr.ramdisk_image) + k_dtb = real_mode->hdr.ramdisk_image; + else { + k_dtb = real_mode->alt_mem_k; + k_dtb++; + k_dtb *= 1024; + } + if (k_dtb > 128 * 1024 * 1024) + k_dtb = 128 * 1024 * 1024; + k_dtb -= (_dtb_end - _dtb_start); + if (!IS_ALIGNED(k_dtb, 4096)) { + /* align down */ + k_dtb = ALIGN(k_dtb, 4096); + k_dtb -= 4096; + } + real_mode->hdr.setup_data = + attach_dtb(real_mode->hdr.setup_data, (void *)k_dtb, + _dtb_start, _dtb_end - _dtb_start); + } + if (!quiet) putstr("done.\nBooting the kernel.\n"); return;
diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
index 34d047c..a4924f9 100644
--- a/arch/x86/boot/compressed/vmlinux.lds.S
+++ b/arch/x86/boot/compressed/vmlinux.lds.S@@ -41,6 +41,13 @@ SECTIONS *(.rodata.*) _erodata = . ; } + + _dtb_start = .; + .data..dtb : { + *(.data..dtb) + } + _dtb_end = . ; + .got : { _got = .; KEEP(*(.got.plt))
--
1.7.2.3
>Thierry
Sebastian