Thread (1 message) 1 message, 1 author, 2012-05-18

Re: [PATCH] of: add const to struct of_device_id.data

From: Uwe Kleine-König <hidden>
Date: 2012-05-18 14:43:17

Hello,

On Mon, Apr 23, 2012 at 10:56:21AM +0200, Uwe Kleine-König wrote:
quoted hunk
Drivers should never need to modify the data of a device id. So it can
be const which in turn allows more consts in the driver.

Signed-off-by: Uwe Kleine-König <redacted>
---
this might introduce warnings in drivers that access the data member
without using const, so this is definitly merge window material if it is
considered at all.

 include/linux/mod_devicetable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 501da4c..183f411 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -222,7 +222,7 @@ struct of_device_id
 	char	type[32];
 	char	compatible[128];
 #ifdef __KERNEL__
-	void	*data;
+	const void *data;
 #else
 	kernel_ulong_t data;
 #endif
any thoughts on this one? I got no feed back and it doesn't appear in
next-20120518.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help