Re: [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree.
From: Grant Likely <hidden>
Date: 2012-05-19 06:05:17
Also in:
linux-i2c, linux-mips, lkml
On Thu, 26 Apr 2012 18:20:26 -0700, David Daney [off-list ref] wrote:
From: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> There are three parts to this: 1) Remove the definitions of OCTEON_IRQ_TWSI and OCTEON_IRQ_TWSI2. The interrupts are specified by the device tree and these hard coded irq numbers block the used of the irq lines by the irq_domain code. 2) Remove platform device setup code from octeon-platform.c, it is now unused. 3) Convert i2c-octeon.c to use device tree. Part of this includes using the devm_* functions instead of the raw counterparts, thus simplifying error handling. No functionality is changed. Signed-off-by: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> Acked-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Is the DT binding for this device documented? Otherwise the code looks good. Please make sure the binding documentation is in place before merging. g.