Thread (8 messages) 8 messages, 5 authors, 2012-05-04

Re: [PATCH 1/1] ARM: tegra: Add Tegra Memory Controller(MC) driver

From: Olof Johansson <hidden>
Date: 2012-05-03 20:13:26
Also in: linux-arm-kernel, linux-tegra, lkml

Hi,

On Thu, May 3, 2012 at 11:39 AM, Stephen Warren [off-list ref] wrote:
On 05/03/2012 10:51 AM, Hiroshi DOYU wrote:
quoted
Tegra Memory Controller(MC) driver for Tegra20/30.
Added to support MC General interrupts, mainly for IOMMU.
quoted
The location of a file may not be suitable because of xxx_driver under arch/arm/mach-*.
---
diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
Russell, Olof, Arnd,

Where should this driver be placed? It's a completely Tegra-specific
module, and I don't believe there's any drivers/ directory or other
subsystem that's appropriate to house it right now. Should we go ahead
and create a drivers/arm/ for this? Perhaps drivers/misc/?
TI just added their memory driver in drivers/memory, and it was merged
through Greg K-H's driver tree. That would be a good location for this
one as well.
Honestly, to me it seems best to keep purely platform-specific drivers
like this in arch/arm/mach-tegra, since that's the most closely
Tegra-related directory.
Since tegra has a custom memory controller it's not as obvious that it
needs to go in a shared location, indeed. But it's easier to use the
same practices across platforms, and if there are other vendors that
end up sharing IP blocks for memory down the road, having them in a
common location makes sense.


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help