Re: [PATCH] pinctrl: fix signed vs unsigned conditional inside pinmux_map_to_setting

On 23/04/12 17:52, Stephen Warren wrote:

On 04/23/2012 02:12 AM, John Crispin wrote:

quoted

pinmux_map_to_settingi() uses setting->data.mux.func to store the return code of
pinmux_func_name_to_selector(). However, struct pinctrl_setting_mux defines the
func element as unsigned, resulting in all error codes getting lost. The
conditional following the assignment will always evaluate to false thus breaking
the error path.

This makes sense.

The exact same issue applies to the assignment to
setting->data.mux.group just a little below. Can you fix that up too please?

missed the group thing, patch coming up ....