Re: [PATCH] staging:iio:adc: Add SPEAr ADC driver

On Wednesday 11 April 2012 15:40:52 Jonathan Cameron wrote:

On 4/11/2012 2:19 PM, Stefan Roese wrote:

quoted

This patch implements the basic single data conversion support for
the SPEAr600 SoC ADC. The register layout of SPEAr600 differs a bit
from other SPEAr SoC variants (e.g. SPEAr3xx). These differences are
handled via DT compatible testing. Resuling in a multi-arch binary.

Resulting

quoted

This driver is currently tested only on SPEAr600. Futur patches may add
support for other SoC variants (SPEAr3xx) and features like software
buffer or DMA.

Future

Ironically that's about it wrt to comments. Couple of totally trivial
bits inline.
Basically I'm happy, so if/when someone acks the device tree side of
things, please
clean up the trivial bits and send on to GregKH.

Nice short, clean driver.  The small line count lured me into reviewing
it ahead of
some others in my review pile!

Jonathan, thanks for the quick review. I'll address you comments and send an 
updated patch shortly.

Stefan