Re: [PATCH] dtc: Basic integer expressions

On 04/09/2012 08:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:

On 20:56 Tue 03 Apr     , Stephen Warren wrote:

quoted

Written by David Gibson [off-list ref]. Additions by me:
* Ported to ToT dtc.
* Renamed cell to integer throughout.
* Implemented value range checks.
* Allow U/L/UL/LL/ULL suffix on literals.
* Enabled the commented test.

Signed-off-by: Stephen Warren <redacted>
---
v3:
* Fix printf warning by s/%ld/%zd/
* Support plain "U" as an integer literal suffix
* Fix misplaced semi-colons in grammar
* Support integer expressions for /memreserve/ and /incbin/ too
* Modify eval_literal to check U/L suffixes after strtoull call,
  using strspn/strlen
* Remove mention of libfdt from comment in tests/integer-expressions.c
* Add comment to explain integer_prim range check
v2:
* s/cell/integer/ throughout.
* Allow signed-extended values to pass the overall cell range check.
* Allow L/UL/LL/ULL suffix on literals. This is purely for compatibility
  with C, and has no effect on dtc's processing.
* Enabled the 3 disabled tests.

Stephen what is the status of the define value?

You mean /define/ VAR VALUE? It's on hold right now; I've been waiting
for this patch to be merged before trying to push that, since one of the
objections against the /define/ patch was that we didn't know what the
future dtc expressions syntax would look like, and hence couldn't tell
whether /define/ fit into it. Now at least we know what integer
expressions look like, so can perhaps start thinking about /define/
syntax again...