Re: [PATCH 1/2] ARM: VIC: Create common infrastructure for vic DT bindings

On 03/25/2012 02:31 AM, viresh kumar wrote:

On Fri, Mar 23, 2012 at 6:10 PM, Rob Herring [off-list ref] wrote:

quoted

NAK

None of these platforms have gpio interrupts or any other board
interrupt controllers which need to be initialized early?

Atleast SPEAr600 have GPIO interrupts.

quoted

I don't think DT conversions are complete enough to tell.

Couldn't get your comment, sorry.

Some DT enabled platforms may only have the gic or vic included in their
match list currently because other interrupt controllers aren't yet
converted to DT. I believe Exynos is one such example.

quoted

We could do something like this, but there only needs to be a single
match list of all controllers and function. We should consolidate the
irqchips to drivers/irqchip first though. I have that action from Connect...

That would be good.
I am updating DT support for SPEAr3xx, where i need to use VIC OF
support. So i would still like to get this patch going and you can consilidate
code at irqchips level later. What do you say?

No. I don't think moving this into the gic and vic code just to move it
back out later is a good idea. Just looking at the diffstat, the net
number of lines removed is not very compelling either.

Rob

--
viresh