Re: [PATCH V2 2/3] ARM: kirkwood: Convert orion-nand to fdt
From: Arnd Bergmann <hidden>
Date: 2012-03-24 19:01:00
Also in:
linux-arm-kernel
On Saturday 24 March 2012, Jamie Lentin wrote:
Convert orion-nand to use fdt and add common setup to kirkwood.dtsi, including a default value for chip-delay (all current boards seem to use 25 anyway). Add placeholder documentation for the bindings, for someone more knowledgable than me to fill in the details of the properties.
Looks very good. Two small comments:
quoted hunk
diff --git a/Documentation/devicetree/bindings/mtd/orion-nand.txt b/Documentation/devicetree/bindings/mtd/orion-nand.txt new file mode 100644 index 0000000..d347999 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/orion-nand.txt@@ -0,0 +1,46 @@ +NAND support for Marvell Orion SoC platforms + +Required properties: +- compatible : "mrvl,orion-nand". +- reg : Base physical address of the NAND and length of memory mapped + region + +Optional properties: +- cle : +- ale : +- width : +- chip-delay :
I think the "width" property should be called "bank-width" to match the other bindings.
+Examples:
+
+nand@f4000000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ cle = <0>;
+ ale = <1>;
+ width = <8>;
+ chip-delay = <25>;
+ compatible = "mrvl,orion-nand";
+ reg = <0xf4000000 0x400>;
+
+ partition@0 {
+ label = "u-boot";
+ reg = <0x0000000 0x100000>;
+ read-only;
+ };You don't describe the partitions in the binding. Others have the same omission, but I think it's worth mentioning. Either point to the mtd-physmap.txt file, or make your patch move the partition support into a new file that everything else can refer to. Arnd