Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

On 3/15/2012 7:09 PM, Arnd Bergmann wrote:

On Thursday 15 March 2012, Stefan Roese wrote:

quoted

On Thursday 15 March 2012 10:00:27 Viresh Kumar wrote:

quoted

On 3/15/2012 2:18 PM, Stefan Roese wrote:

quoted

quoted

quoted

quoted

quoted

+static const struct of_device_id vic_of_match[] __initconst = {
+     { .compatible = "arm,pl190-vic", .data = vic_of_init, },
+     { /* Sentinel */ }
+};
+
+static void __init spear6xx_dt_init_irq(void)
+{
+     of_irq_init(vic_of_match);
+}
+

What about adding this routine in vic.c file, which can then be used
by all platforms, instead of replicating this code.

We can't move vic_of_match to the vic.c, since there are differences
between the boards using it. And only moving spear6xx_dt_init_irq()
(renamed of course) doesn't seem worth it.

I knew this. Actually my thought was, we have two compatible strings for
vic: pl190 and pl192.

So, create two vic_of_match* arrays and two vic*_dt_init_irq() routines.
That will solve the issue i believe.

I still don't think its worth it. But please feel free to send an add-on 
patch, to "clean this up".

What's wrong with one vic_dt_init_irq() function and an array with two entries?

Hey Arnd,

Actually i was doing 3xx DT porting and again came to this thing. I believe what
you suggested should be fine too as the actual vic model/name is going to be
passed from .dts file.

If this is acceptable to you, i will add patch for both vic & gic in my
patchset.

-- 
viresh